JSON parsing changes from new product query #282
Conversation
|
@phlexbot format |
|
No automatic markdownlint fixes were necessary. |
|
No automatic cmake-format fixes were necessary. |
|
Automatic clang-format fixes pushed (commit 4312595). |
Eliminates need for default constructor
beojan
force-pushed
the
boost-json-no-def-const
branch
from
4312595 to
1bf6bbf
Compare
|
@phlexbot format |
|
No automatic markdownlint fixes were necessary. |
|
No automatic cmake-format fixes were necessary. |
|
Automatic clang-format fixes pushed (commit aaebf2f35f01dadbb762c5d8a1716598c9a5c059). |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (14.28%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #282 +/- ##
==========================================
- Coverage 75.20% 74.28% -0.93%
==========================================
Files 124 124
Lines 2916 2955 +39
Branches 513 513
==========================================
+ Hits 2193 2195 +2
- Misses 503 540 +37
Partials 220 220
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
left a comment
knoepfel
left a comment
There was a problem hiding this comment.
LGTM. We should make sure the value_if_exists function is tested when it is eventually used. It will not hold up this PR, though
2 participants
This eliminates need for default constructor.
See #267